diff: remove write cache #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crack the write instructions before we construct the PATCH instructions, so that we can do our cached write pass before PATCH construction. Signed-off-by: Jordan Yates <jordan@embeint.com>
The overhead of the cache was approximately the same as the write data savings, but significantly increases the complexity of both sides of the patching algorithm. Signed-off-by: Jordan Yates <jordan@embeint.com>
Add the option to create a validation patch file that exercises all of the instructions available to duplicate an input image. Signed-off-by: Jordan Yates <jordan@embeint.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overhead of the cache was approximately the same as the write data
savings, but significantly increases the complexity of both sides of the
patching algorithm.