Skip to content

Implement MERGE INTO #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 20, 2025
Merged

Implement MERGE INTO #147

merged 8 commits into from
Jan 20, 2025

Conversation

@osipovartem
Copy link
Contributor

@osipovartem osipovartem commented Jan 16, 2025 •
edited
Loading

Closes #74

  • Parse MERGE INTO statement as insert as select
  • Fallback to NOT MATCH part as default insert
  • Skip ALTER TABLE. The implementation will be added in a separate issue - engine: support alter table statement #146
  • removed some funcs which were copied from datafusion
  • fixed query processing regex for json_get
  • added full error message into response

@osipovartem
# This is a combination of 14 commits.
8c0979b 
# This is the 1st commit message:

Upload CSV to table

# This is the commit message #2:

Upload CSV to table

# This is the commit message #3:

Fix linter

# This is the commit message #4:

Remove unused error

# This is the commit message #5:

Fix clippy

# This is the commit message #6:

Fix clippy

# This is the commit message #7:

Fix linter

# This is the commit message #8:

Fix clippy

# This is the commit message #9:

Fix clippy

# This is the commit message #10:

Fix clippy

# This is the commit message #11:

Fix fmt

# This is the commit message #12:

Add pre-commit

# This is the commit message #13:

Parse merge into

# This is the commit message #14:

Parse merge into
@osipovartem
Merge
42a9005
@osipovartem osipovartem force-pushed the issues/74-merge_table branch from f756b1a to 42a9005 Compare January 16, 2025 10:52
eadgbear
eadgbear reviewed Jan 16, 2025
View reviewed changes
DanCodedThis
DanCodedThis previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@DanCodedThis DanCodedThis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Vedin
Vedin approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Vedin Vedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it as is and create follow-up issues.

@osipovartem osipovartem merged commit 8cf66a1 into main Jan 20, 2025
0 of 4 checks passed
@osipovartem osipovartem deleted the issues/74-merge_table branch January 20, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vedin Vedin Vedin approved these changes

@DanCodedThis DanCodedThis DanCodedThis left review comments

@rampage644 rampage644 Awaiting requested review from rampage644

+1 more reviewer

@eadgbear eadgbear eadgbear left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

engine: Implement MERGE INTO statement

5 participants

@osipovartem @eadgbear @Vedin @DanCodedThis