Skip to content

Enable text selection in iOS and Android comments #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

Enable text selection in iOS and Android comments #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5e9147
Enable text selection in iOS comments
runningcode Sep 30, 2025
eb0feac
Enable text selection in Android comments
runningcode Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions ...d/app/src/main/java/com/emergetools/hackernews/features/comments/components/CommentRow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import androidx.compose.animation.core.tween
import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.text.selection.SelectionContainer
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
Expand Down Expand Up @@ -126,12 +127,14 @@ fun CommentRow(
}
}
if (state.hidden == HiddenStatus.Displayed) {
Text(
text = state.content.parseAsHtml(),
style = MaterialTheme.typography.labelSmall,
fontWeight = FontWeight.Normal,
color = MaterialTheme.colorScheme.onSurface,
)
SelectionContainer {
Text(
text = state.content.parseAsHtml(),
style = MaterialTheme.typography.labelSmall,
fontWeight = FontWeight.Normal,
color = MaterialTheme.colorScheme.onSurface,
)
}
}
}
}
Expand Down
1 change: 1 addition & 0 deletions ios/HackerNews/Comments/CommentRow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ struct CommentRow: View {
Text(state.text.formattedHTML())
.font(theme.commentTextFont)
.tint(.accentColor)
.textSelection(.enabled)
}
.frame(maxWidth: .infinity, alignment: .leading)
.padding(EdgeInsets(top: -3, leading: 8, bottom: 8, trailing: 8))
Expand Down
Loading