Utils restructure #219
Merged
Utils restructure #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all was directly assigned to the module.exports object. Now it is somewhat more structured. First properties are listed. Next modules.exports is defined, giving an overview of the module. Last named functions are declared. This provides better stacktraces.
Owner
There was a problem hiding this comment.
If these are not considered as service, I think this is a mistake. We should update this isAngularServiceDeclaration method in order to support these exta syntaxes.
Collaborator
Author
There was a problem hiding this comment.
That's why I wanted someone else to take a look at the docs I added and see if they are correct. If these docs are correct I would like to add tests and fix the issues I marked with @todo FIXME.
Owner
|
for me, the doc looks good. |
These tests uncover some issues that need to be looked over.
Collaborator
|
looks good for me too. I'll merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these patches uncover some issues with the utils. Also the utils are untested.
I would like to make tests for them and fix those issues if I'm sure I've got the documentation right.