Skip to content

add missing example for typecheck-array (fixes #291) #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2015
Merged

add missing example for typecheck-array (fixes #291) #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d9a989
add missing example for typecheck-array (fixes #291)
tilmanschweitzer Dec 4, 2015
abdaf5d
Merge branch 'development' into issue-291/Doc-isArray--Wrong-example
tilmanschweitzer Dec 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/typecheck-array.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ The following patterns are considered problems;
// invalid
Object.prototype.toString.call(someArray) === '[object Array]'; // error: You should use the angular.isArray method

// invalid
Array.isArray(someArray) // error: You should use the angular.isArray method

The following patterns are **not** considered problems;

/*eslint angular/typecheck-array: 2*/
Expand Down
3 changes: 3 additions & 0 deletions examples/typecheck-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,6 @@ angular.isArray(someArray);

// example - valid: false, errorMessage: "You should use the angular.isArray method"
Object.prototype.toString.call(someArray) === '[object Array]';

// example - valid: false, errorMessage: "You should use the angular.isArray method"
Array.isArray(someArray)