Skip to content

Add new dumb-inject rule #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2015
Merged

Add new dumb-inject rule #303

merged 4 commits into from
Dec 8, 2015

Conversation

@remcohaszing
Copy link
Collaborator

@remcohaszing remcohaszing commented Dec 6, 2015

This closes #213

@remcohaszing remcohaszing added this to the 0.15.0 milestone Dec 6, 2015
tilmanschweitzer
tilmanschweitzer reviewed Dec 6, 2015
View reviewed changes
index.js Outdated
Copy link
Collaborator

@tilmanschweitzer tilmanschweitzer Dec 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed to 0. We already have an issue about not enabling rules by default #258.

Copy link
Collaborator Author

@remcohaszing remcohaszing Dec 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I seem to have failed at copy-pasting.

remcohaszing and others added 2 commits December 6, 2015 21:50
@remcohaszing
Disable dumb-inject rule by default
adf9f0c 
New rules may not be enabled by default, as this would be a breaking change for existing setups.
@tilmanschweitzer
change legacy node in travis.yml from 0.10 to 0.12
8129487
@tilmanschweitzer
Copy link
Collaborator

tilmanschweitzer commented Dec 6, 2015

+1

Looks good to me.

@remcohaszing
Merge pull request #3 from tilmanpotthof/dumb-inject
0fc498c 
change legacy node in travis.yml from 0.10 to 0.12
EmmanuelDemey added a commit that referenced this pull request Dec 8, 2015
@EmmanuelDemey
Merge pull request #303 from remcohaszing/dumb-inject
b60e1ac 
Add new dumb-inject rule
@EmmanuelDemey EmmanuelDemey merged commit b60e1ac into EmmanuelDemey:development Dec 8, 2015
@remcohaszing remcohaszing deleted the dumb-inject branch December 9, 2015 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Rule

Projects

None yet

Milestone

0.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@remcohaszing @tilmanschweitzer @EmmanuelDemey