Performance/extract require utils

.eslintrc

@@ -118,6 +118,7 @@ rules:
 
   # http://eslint.org/docs/rules/#nodejs
   callback-return: 2
+  global-require: 2
   handle-callback-err:
     - 2
     - ^(e|err|error)$

rules/controller-as-route.js

@@ -9,9 +9,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
         CallExpression: function(node) {
             var routeObject = null;

rules/controller-as-vm.js

@@ -11,8 +11,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     var badStatements = [];
     var badCaptureStatements = [];
     var controllerFunctions = [];

rules/controller-as.js

@@ -11,8 +11,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     var badStatements = [];
     var controllerFunctions = [];
 

rules/controller-name.js

@@ -12,9 +12,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         CallExpression: function(node) {

rules/di.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     var angularNamedObjectList = ['value', 'factory', 'service', 'provider', 'controller', 'filter', 'directive'];
 
     function report(node, syntax) {

rules/directive-name.js

@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     if (context.settings.angular === 2) {
         return {};
     }

rules/directive-restrict.js

@@ -12,9 +12,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     var options = context.options[0] || {};
     var restrictOpt = options.restrict || 'AE';
     var explicitRestrict = options.explicit === 'always';

rules/empty-controller.js

@@ -9,9 +9,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function report(node, name) {
         context.report(node, 'The {{ctrl}} controller is useless because empty. You can remove it from your Router configuration or in one of your view', {
             ctrl: name

rules/file-name.js

@@ -13,9 +13,11 @@
  */
 'use strict';
 
+var path = require('path');
+
+var utils = require('./utils/utils');
+
 module.exports = (function() {
-    var utils = require('./utils/utils');
-    var path = require('path');
     var fileEnding = '.js';
 
     var separators = {

rules/filter-name.js

@@ -10,9 +10,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         CallExpression: function(node) {

rules/function-type.js

@@ -12,8 +12,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
+
 module.exports = function(context) {
-    var utils = require('./utils/utils');
     var angularObjectList = ['animation', 'config', 'constant', 'controller', 'directive', 'factory', 'filter', 'provider', 'service', 'value', 'decorator'];
     var configType = context.options[0] || 'anonymous';
     var messageByConfigType = {

rules/module-dependency-order.js

@@ -14,9 +14,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     var options = context.options[0] || {};
     var groupedMode = options.grouped !== false;
     var moduleRegex;

rules/module-getter.js

@@ -10,9 +10,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         ExpressionStatement: function(node) {

rules/module-name.js

@@ -11,9 +11,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         CallExpression: function(node) {

rules/module-setter.js

@@ -10,10 +10,9 @@
  */
 'use strict';
 
+var utils = require('./utils/utils');
 
 module.exports = function(context) {
-    var utils = require('./utils/utils');
-
     return {
 
         VariableDeclaration: function(node) {

rules/no-controller.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         CallExpression: function(node) {

rules/no-service-method.js

@@ -9,9 +9,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         CallExpression: function(node) {

rules/no-services.js

@@ -12,9 +12,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     var angularObjectList = ['controller', 'filter', 'directive'];
     var badServices;
     var map;

rules/rest-service.js

@@ -9,9 +9,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     var angularObjectList = ['controller', 'filter', 'directive', 'service', 'factory', 'provider'];
     var services = ['$http', '$resource', 'Restangular'];
     var message = 'You should use the same service ({{method}}) for REST API calls';

rules/service-name.js

@@ -11,9 +11,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     return {
 
         CallExpression: function(node) {

rules/typecheck-array.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && node.value === '[object Array]') {
             context.report(origin, 'You should use the angular.isArray method', {});

rules/typecheck-date.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && node.value === '[object Date]') {
             context.report(origin, 'You should use the angular.isDate method', {});

rules/typecheck-function.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'function' || node.value === '[object Function]')) {
             context.report(origin, 'You should use the angular.isFunction method', {});

rules/typecheck-number.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'number' || node.value === '[object Number]')) {
             context.report(origin, 'You should use the angular.isNumber method', {});

rules/typecheck-object.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'object' || node.value === '[object Object]')) {
             context.report(origin, 'You should use the angular.isObject method', {});

rules/typecheck-regexp.js

@@ -9,9 +9,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && node.value === '[object RegExp]') {
             context.report(origin, 'You should use the angular.isRegexp method', {});

rules/typecheck-string.js

@@ -8,9 +8,9 @@
  */
 'use strict';
 
-module.exports = function(context) {
-    var utils = require('./utils/utils');
+var utils = require('./utils/utils');
 
+module.exports = function(context) {
     function recordError(node, origin) {
         if (node.type === 'Literal' && (node.value === 'string' || node.value === '[object String]')) {
             context.report(origin, 'You should use the angular.isString method', {});

rules/utils/rulesConfiguration.js

@@ -3,7 +3,7 @@
 function Rule(name, config) {
     this.name = name;
     this.config = config;
-    this._requireRule = require('../' + this.name);
+    this._requireRule = require('../' + this.name);  // eslint-disable-line global-require
 }
 
 Rule.prototype = {

scripts/docs.js

@@ -3,7 +3,8 @@
 var fs = require('fs');
 var parseComments = require('parse-comments');
 var _ = require('lodash');
-var eslintAngularIndex = require('../index.js');
+var eslintAngularIndex = require('../index');
+var ruleCategories = require('./ruleCategories.json');
 var RuleTester = require('eslint').RuleTester;
 
 var templates = require('./templates.js');
@@ -41,8 +42,6 @@ function createDocFiles(cb) {
  * @param cb callback
  */
 function updateReadme(readmePath, cb) {
-    var ruleCategories = require('./ruleCategories.json');
-
     ruleCategories.rulesByCategory = _.groupBy(this.rules, 'category');
 
     // filter categories without rules
@@ -192,7 +191,7 @@ function _createRule(ruleName) {
     }
 
     // load rule module for tests
-    rule.module = require('../rules/' + rule.ruleName);
+    rule.module = require('../rules/' + rule.ruleName);  // eslint-disable-line global-require
 
     // load examples, prepare them for the tests and group the for the template
     rule.allExamples = _loadExamples(rule);