Skip to content

Issue/99 angular/ng di false positive for array constants #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2015
Merged

Issue/99 angular/ng di false positive for array constants #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22caa4e
add tests for di false positives (#99)
tilmanschweitzer Dec 6, 2015
217e389
remove value from di checks (fixes #99)
tilmanschweitzer Dec 6, 2015
039562a
Merge branch 'development' into issue/99-angular/ng_di-false-positive…
tilmanschweitzer Dec 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/di.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
var utils = require('./utils/utils');

module.exports = function(context) {
var angularNamedObjectList = ['value', 'factory', 'service', 'provider', 'controller', 'filter', 'directive'];
var angularNamedObjectList = ['factory', 'service', 'provider', 'controller', 'filter', 'directive'];

function report(node, syntax) {
context.report(node, 'You should use the {{syntax}} syntax for DI', {
Expand Down
14 changes: 13 additions & 1 deletion test/di.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ var RuleTester = require('eslint').RuleTester;
var commonFalsePositives = require('./utils/commonFalsePositives');


var angularNamedObjectList = ['value', 'factory', 'service', 'provider', 'controller', 'filter', 'directive'];
var angularNamedObjectList = ['factory', 'service', 'provider', 'controller', 'filter', 'directive'];
var angularObjectList = ['run', 'config'];


Expand Down Expand Up @@ -153,7 +153,19 @@ valid.push({
}, {
code: 'mocha.run();',
options: ['array']
}, {
code: 'mocha.run();',
options: ['array']
}, {
// value false positive with function
code: 'angular.module("") .value("", function () {});',
options: ['array']
}, {
// value false positive with array (example from issue #99)
code: 'angular.module("") .value("", [{ }, { }]);',
options: ['function']
});

// ------------------------------------------------------------------------------
// Tests
// ------------------------------------------------------------------------------
Expand Down