Skip to content

Angular rule coverage #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2015
Merged

Angular rule coverage #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
752cd89
Remove duplicate check from angular-rule
remcohaszing Dec 6, 2015
590ed2e
Add potential failing crashes
remcohaszing Dec 6, 2015
396267a
Add potential failures for component definitions
remcohaszing Dec 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions rules/utils/angular-rule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,6 @@ function angularRule(ruleDefinition) {
function findFunctionByNode(callExpressionNode, scope) {
var node;
if (callExpressionNode.callee.type === 'Identifier') {
if (callExpressionNode.callee.name !== 'inject') {
return;
}
node = callExpressionNode.arguments[0];
} else if (callExpressionNode.callee.property.name === 'run' || callExpressionNode.callee.property.name === 'config') {
node = callExpressionNode.arguments[0];
Expand Down
10 changes: 10 additions & 0 deletions test/component-limit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,17 @@ eslintTester.run('component-limit', rule, {
'angular.module("").factory();',
'angular.module("").filter();',
'angular.module("").provider();',
'angular.module("").run();',
'angular.module("").service();',
'angular.module("").animation("", "");',
'angular.module("").config("");',
'angular.module("").controller("", "");',
'angular.module("").directive("", "");',
'angular.module("").factory("", "");',
'angular.module("").filter("", "");',
'angular.module("").provider("", "");',
'angular.module("").run("");',
'angular.module("").service("", "");',
// Identified potential false positives
'$scope.$on("", function() {});$scope.$on("", function() {});',
'app.service("", function(myService) { var data = {}; myService.someMethod("", data); });',
Expand Down
10 changes: 10 additions & 0 deletions test/di-order.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ eslintTester.run('di-order', rule, {
'inject(function($http, $q) {});',
'it(inject(function($http, $q) {}));',
'it(inject(function(_$http_, _$httpBackend_) {}));',
// Potential crashes
'angular.module("").animation("", "");',
'angular.module("").config("");',
'angular.module("").controller("", "");',
'angular.module("").directive("", "");',
'angular.module("").factory("", "");',
'angular.module("").filter("", "");',
'angular.module("").provider("", "");',
'angular.module("").run("");',
'angular.module("").service("", "");',
{
code: 'it(inject(function(_$httpBackend_, _$http_) {}));',
options: [false]
Expand Down
12 changes: 11 additions & 1 deletion test/di-unused.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,17 @@ eslintTester.run('di-unused', rule, {
'angular.module("").run(["$q", function($q) {return $q;}]);',
'inject(function($q) {_$q_ = $q;});',
'angular.module("").provider("", function() {this.$get = function($q) {return $q};});',
'angular.module("").provider("", function() {this.$get = ["$q", function($q) {return $q}];});'
'angular.module("").provider("", function() {this.$get = ["$q", function($q) {return $q}];});',
// Potential crashes
'angular.module("").animation("", "");',
'angular.module("").config("");',
'angular.module("").controller("", "");',
'angular.module("").directive("", "");',
'angular.module("").factory("", "");',
'angular.module("").filter("", "");',
'angular.module("").provider("", "");',
'angular.module("").run("");',
'angular.module("").service("", "");'
].concat(commonFalsePositives),
invalid: [
// animation
Expand Down
12 changes: 11 additions & 1 deletion test/no-run-logic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,17 @@ eslintTester.run('no-run-logic', rule, {
'angular.module("").run(function() {foo(null)});',
'angular.module("").run(function() {foo(undefined)});',
'angular.module("").run(function() {foo("bar")});',
'angular.module("").run(function() {foo(bar)});'
'angular.module("").run(function() {foo(bar)});',
// don't crash on component definitions
'angular.module("").animation();',
'angular.module("").config();',
'angular.module("").controller();',
'angular.module("").directive();',
'angular.module("").factory();',
'angular.module("").filter();',
'angular.module("").provider();',
'angular.module("").run();',
'angular.module("").service();'
],
invalid: [
// Nested function declarations
Expand Down