Sega Genesis C/Z buttons in Control Settings

[mikhailv]

I can't configure C/Z buttons for Sega Genesis in controller settings screen.

There was a similar issue #1018 with fix.

But I think the fix was addressed to Virtual Gamepad only, but not for controller settings screen.

Should segaMD also be included in this place ?

EmulatorJS/data/src/emulator.js

Line 2622 in dfe9498

} else if (["segaCD", "sega32x"].includes(this.getControlScheme())) {

[mikhailv]

In original issue there is link to page with emulator, it has modified version of emulator where "segaMD" added in both places and control settings dialog is showing correct mapping for sega controller with C/Z buttons.

[zmarteline]

Edit emulatot.js, find and remove current segaMD control section entirely, find segaCD section and include segamd on current segaCD section, like this:

    } else if (["segaMD", "segaCD", "sega32x"].includes(this.getControlScheme())) {
        info = [
            { "type": "button", "text": "A", "id": "a", "location": "right", "right": 145, "top": 70, "bold": true, "input_value": 1 },
            { "type": "button", "text": "B", "id": "b", "location": "right", "right": 75, "top": 70, "bold": true, "input_value": 0 },
            { "type": "button", "text": "C", "id": "c", "location": "right", "right": 5, "top": 70, "bold": true, "input_value": 8 },
            { "type": "button", "text": "X", "id": "x", "location": "right", "right": 145, "top": 0, "bold": true, "input_value": 10 },
            { "type": "button", "text": "Y", "id": "y", "location": "right", "right": 75, "top": 0, "bold": true, "input_value": 9 },
            { "type": "button", "text": "Z", "id": "z", "location": "right", "right": 5, "top": 0, "bold": true, "input_value": 11 },
            { "type": "dpad", "id": "dpad", "location": "left", "left": "50%", "right": "50%", "joystickInput": false, "inputValues": [4, 5, 6, 7] },
            { "type": "button", "text": "Mode", "id": "mode", "location": "center", "left": -5, "fontSize": 15, "block": true, "input_value": 2 },
            { "type": "button", "text": "Start", "id": "start", "location": "center", "left": 60, "fontSize": 15, "block": true, "input_value": 3 }
        ];

This will give you correct Genesis buttons...

[mikhailv]

@zmarteline There is no segaMD section to remove, also you can see that I already created PR to fix the issue. The question in this issue was exactly to clarify should "segaMD" to be included in this place or not, and why it was not included in initial issue fix.

[ethanaobrien]

@mikhailv Thank you for submitting a PR to fix this issue for everyone

[zmarteline]

@ethanaobrien Nice to see that now we have the correct layout, as requested # #1046.

[ethanaobrien]

You're welcome to submit a PR after performing the needed tests.