Skip to content

Conversation

@KingIzzymon
Copy link
Contributor

I completed updating documentation to todays code.

  • Updated main page to include "not affiliated with linuxserver/emulatorjs"
  • Added several pages under "Docs" section
  • Added Roadmap & News pages to keep community informed
  • Included link to the project changelog
  • Organized the files into "docs" and "docs4devs" folders to mimic website for ease of editing

@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for emulatorjs ready!

Name Link
🔨 Latest commit febdec1
🔍 Latest deploy log https://app.netlify.com/sites/emulatorjs/deploys/637165298cfaba000821587d
😎 Deploy Preview https://deploy-preview-14--emulatorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ethanaobrien
Copy link
Member

ethanaobrien commented Nov 13, 2022

I made some comments for questions I had. Could you also delete the src/.vuepress/public/data/ folder, since this is no longer needed (because I put the demo in its own domain)

Thanks for all your help! The site looks much better!

@KingIzzymon
Copy link
Contributor Author

Hey boss, I'm having trouble finding your comments. Where did you put them?

@ethanaobrien
Copy link
Member

I commented on the commits, you should be able to see it in the files changed tab or the conversation tab

@KingIzzymon
Copy link
Contributor Author

I might be having a blonde moment here since I havent used github in a while... but I've checked through this conversation tab and through each of my commits in the commit tab and still cant find your comments.

Capture

@ethanaobrien
Copy link
Member

If you scroll down a bit
Screenshot 2022-11-13 1 51 09 PM

@KingIzzymon
Copy link
Contributor Author

This is so weird, its not showing up for me. I never even got notifications of your comments...

@ethanaobrien
Copy link
Member

Strange, do you want me to just send you screenshots of everything?

@KingIzzymon
Copy link
Contributor Author

Sure if its not too much trouble, but I still wanna know why I cant see comments or if others can.

@ethanaobrien
Copy link
Member

I looked, not sure why I'm the only one that can see it but it is a problem. This is really weird

@ethanaobrien
Copy link
Member

Screenshot 2022-11-13 2 06 40 PM
Screenshot 2022-11-13 2 06 49 PM
Screenshot 2022-11-13 2 07 09 PM
Screenshot 2022-11-13 2 07 24 PM
Screenshot 2022-11-13 2 07 35 PM
Screenshot 2022-11-13 2 07 41 PM
Screenshot 2022-11-13 2 07 46 PM
Screenshot 2022-11-13 2 07 56 PM
Screenshot 2022-11-13 2 08 02 PM

@KingIzzymon
Copy link
Contributor Author

Quick question, who actually created this logo? Having you or linuxserver/emulatorjs change their logo to something different would help alot with the confusion.

logo

@ethanaobrien
Copy link
Member

I'm not completely sure, allancoding got the logo. If you could make a new logo I'd appreciate that

@KingIzzymon
Copy link
Contributor Author

Sure thing, I'll work on that after the documentation.

Should I open a new issue and submit my drafts there? To keep the conversations concise.

@ethanaobrien
Copy link
Member

Sure, whatever you prefer.

@KingIzzymon
Copy link
Contributor Author

KingIzzymon commented Nov 13, 2022

Which file has the right": "50% typos?

UPDATE: nvm found it on my second pass

Removed the "Basic controls" section which was meant for another project.
Updated Roadmap.
Added contributors array to `package.json`.
Fixed typos.
@KingIzzymon
Copy link
Contributor Author

Alright, that should be it.

Summary

For npm's "package.json" file, they don't allow an author array, but I made a contributors array and added myself and Allan.

Regarding the "Client setup" sections, its just describes how to make a shortcut on your home page on a phone or, for the steam deck, to open chrome in kiosk mode (works on windows too). Give it a try and test with something like youtube.

I removed the "Basic controls" section. It was leftover from when I thought you were the linuxserver version...

The issue you mentioned about retroachievements, is that coming all the way from libretro? I use retroachievements and it requires internet while playing, downloads your current achievements on launch and autoupdates as you unlock more. At least that's how I believe it works... I'm definitely interested in learning more.

@ethanaobrien
Copy link
Member

The issue you mentioned about retroachievements, is that coming all the way from libretro? I use retroachievements and it requires internet while playing, downloads your current achievements on launch and autoupdates as you unlock more. At least that's how I believe it works... I'm definitely interested in learning more.

I didn't know this. I'll look more into this when I can

@ethanaobrien
Copy link
Member

Looks good! Thank you for your help!

@ethanaobrien ethanaobrien merged commit 9cdae0f into EmulatorJS:main Nov 13, 2022
allancoding pushed a commit that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants