Skip to content

Conversation

@alessandrokonrad
Copy link
Contributor

I added the hash functions for datum and script data.

@vsubhuman vsubhuman self-requested a review September 14, 2021 16:09
@alessandrokonrad
Copy link
Contributor Author

alessandrokonrad commented Sep 14, 2021

I forgot to wrap the cost model inside language views (Costmdls):
https://github.com/input-output-hk/cardano-ledger-specs/blob/e59e6ae405e9054966180a26d759b078f8f87329/alonzo/test/cddl-files/alonzo.cddl#L97

Will update that

@vsubhuman
Copy link
Contributor

Thank you, @alessandrokonrad! Reviewing it now

@alessandrokonrad
Copy link
Contributor Author

alessandrokonrad commented Sep 16, 2021

Thank you, @alessandrokonrad! Reviewing it now

Awesome. I'm still struggeling a little bit with the hash_script_data function. Was yet not able to reproduce the same hash in the serialization-lib as in the cardano-cli, although I feel according to the specs it looks correct. The concatenation of redeemers, datums and cost models.

@vsubhuman vsubhuman added this to the 9.0.0 milestone Sep 19, 2021
@vsubhuman vsubhuman merged commit 63e1b71 into Emurgo:master Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants