Skip to content

Conversation

@tsmbland
Copy link
Collaborator

@tsmbland tsmbland commented Jul 3, 2024

Description

In line with the discussion here, I'm changing some of the column titles to be clearer. I've also made the column order more consistent between tables.

@tsmbland tsmbland requested review from alexdewar and cc-a July 3, 2024 15:49
@codecov
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.37%. Comparing base (5f35bae) to head (cf47582).

Additional details and impacted files
@@                Coverage Diff                 @@
##           new-data-input     #398      +/-   ##
==================================================
+ Coverage           71.33%   71.37%   +0.03%     
==================================================
  Files                  44       44              
  Lines                5921     5921              
  Branches             1169     1169              
==================================================
+ Hits                 4224     4226       +2     
+ Misses               1374     1373       -1     
+ Partials              323      322       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmbland tsmbland marked this pull request as ready for review July 3, 2024 16:04
Copy link
Collaborator

@alexdewar alexdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few columns which I think should be just id. I'd request changes but I'm going away and don't want to block merging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I may have missed something, but what are agent pairs about?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because agents have typically been made up of new and retrofit shares, so this is a way to link them together. I might change this later.

@tsmbland tsmbland self-assigned this Jul 3, 2024
@tsmbland tsmbland merged commit 40fcad3 into new-data-input Jul 4, 2024
@tsmbland tsmbland deleted the columns branch July 4, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants