Use aggregate sink for all example models #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalonsoa
approved these changes
Aug 21, 2024
Collaborator
dalonsoa
left a comment
dalonsoa
left a comment
There was a problem hiding this comment.
Another of those small changes that make everyone's life better. Good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since fixing the aggregate sink in #450, it makes sense to actually use it for the example models. This essentially just combines all the sector outputs into a single file for all years, rather than having separate files for each year with overlapping data between files (which I've always found pretty annoying).
There are more lines deleted than added (always satisfying), which is mostly because we now no longer have data duplicated between files. The only other difference is that the previous files included capacity data for existing assets beyond the timeframe of the simulation, which is cropped out in the aggregate files. I don't imagine this being a huge issue though.
(Almost none of these files are actually used in the tutorials, and most users will find everything they need in the MCACapacity and MCASupply files, so I'm tempted to delete most of them anyway, but I'll deal with that another time)