Added notifcation API and eventstore API example #30
Conversation
1. It is able to connect and get invocations 2. Still not getting notifications 3. This uses the engflowapis and its current visibility does not work
|
To build successfully, we need to change the visibility of the engflowapis (that's what @jayconrod agreed on). A PR here. Is there a better way @Yannic ? |
| obtain the notifications for a given build and use the notification data | ||
| to obtain invocation events from the **event store API**. To do so, | ||
| the [EngFlow API](https://github.com/EngFlow/engflowapis) is used as external | ||
| dependency (see [WORKSPACE](../../../../WORKSPACE)). |
There was a problem hiding this comment.
Maybe a brief explanation of the purpose of these APIs? I don't know much about them. What kinds of things might we be notified for? What is the event store?
There was a problem hiding this comment.
I think the description should be in the engflowapis repository as developers really don't need the example repo to use the APIs. I guess all API should be documented there in deep.
Few changes in code and docs
… tokens auth It is possible then to use github tokens for talking with the envoy cluster It is possible then to use .crt and .key files for talking with engflow canary cluster
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Sorry for the slow review. This looks pretty good to me. I'm mainly reviewing for Java / Bazel correctness, so @lfpino and @Yannic may have more domain-specific comments on the APIs.
Make sure to fix and resolve pending comments. You can find them in GitHub on the "Files changed" tag in the "Conversations" drop down.
Progress in engflow repo