Add support for args for DataFetcher declared in method #86
Conversation
|
A thing I've noticed while working on this PR is that there are failing tests in current master branch. |
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-all.zip |
There was a problem hiding this comment.
I guess I should not update this, but I had to otherwise it would not compile in my env. I can revert it back.
There was a problem hiding this comment.
I think the -all distro is ok. IDEA suggests it
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-3.1-all.zip |
There was a problem hiding this comment.
I think the -all distro is ok. IDEA suggests it
| import graphql.schema.GraphQLObjectType; | ||
| import graphql.schema.GraphQLSchema; | ||
| import graphql.schema.PropertyDataFetcher; | ||
| import graphql.schema.*; |
There was a problem hiding this comment.
Can you please use direct imports. If you are using IDEA, set your min imports to 9999
|
Hi @bbakerman, already made the updates based on latest changes. Is there anything else stopping this from being merged? Thanks! |
2 participants
This PR fixes #85
It adds the missing support for passing arguments to DataFetchers declared in GraphQLFields that are declared as method. This extends the existing functionality that was only covered for fields.