-
Notifications
You must be signed in to change notification settings - Fork 2
fix/ensemble-response-mapping #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 079b3b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit 079b3b1): https://react-kitchen-sink-dev--pr969-fix-ensemble-respons-nddx6rls.web.app (expires Thu, 09 Jan 2025 19:06:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a request is in flight then isSuccess should be false/undefined
d93998f to
f88cd73
Compare
packages/framework/src/data/index.ts
Outdated
| isSuccess?: boolean; | ||
| isError?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this need to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This both needs to be optional as we are now just updating the statusCode on API trigger, and isSuccess and isError will update through statusCode by getters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update the function type to take Partial instead of updating the root interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evshi done
Describe your changes
fix/ensemble-response-mapping
basically assign was overwriting the Response isSuccess getter method and thus it was giving type error
Screenshots [Optional]
Issue ticket number and link
Closes #
Checklist before requesting a review
pnpm changeset add