Integration with SpeedyWeather.jl

[giordano]

julia> using Reactant, SpeedyWeather
AssertionError("Could not find registered platform with name: \"cuda\". Available platform names are: ")

julia> spectral_grid = SpectralGrid(trunc=31, nlayers=8);

julia> model = PrimitiveWetModel(spectral_grid);

julia> simulation = initialize!(model);

julia> rsimulation = Reactant.to_rarray(simulation);
ERROR: NoFieldMatchError:
Cannot convert type PrognosticVariables{NF, ArrayType, NSTEPS, SpectralVariable2D, SpectralVariable3D, GridVariable2D, ParticleVector}, best attempt PrognosticVariables{NF, ArrayType, NSTEPS, SpectralVariable2D, SpectralVariable3D, GridVariable2D, ParticleVector} failed.
This could be because the type does not capture the fieldtypes that should be converted in its type parameters.
idx=1 Derived: Int64 Existing: Int64
idx=2 Derived: Int64 Existing: Int64
idx=3 Derived: Int64 Existing: Int64
idx=4 Derived: Int64 Existing: Int64
idx=5 Derived: NTuple{NSTEPS, SpectralVariable3D} Existing: NTuple{NSTEPS, SpectralVariable3D}
idx=6 Derived: NTuple{NSTEPS, SpectralVariable3D} Existing: NTuple{NSTEPS, SpectralVariable3D}
idx=7 Derived: NTuple{NSTEPS, SpectralVariable3D} Existing: NTuple{NSTEPS, SpectralVariable3D}
idx=8 Derived: NTuple{NSTEPS, SpectralVariable3D} Existing: NTuple{NSTEPS, SpectralVariable3D}
idx=9 Derived: NTuple{NSTEPS, SpectralVariable2D} Existing: NTuple{NSTEPS, SpectralVariable2D}
idx=10 Derived: SpectralVariable2D Existing: SpectralVariable2D
idx=11 Derived: PrognosticVariablesOcean{NF, ArrayType, GridVariable2D} Existing: PrognosticVariablesOcean{NF, ArrayType, GridVariable2D}
idx=12 Derived: PrognosticVariablesLand{NF, ArrayType, GridVariable2D} Existing: PrognosticVariablesLand{NF, ArrayType, GridVariable2D}
idx=13 Derived: ParticleVector Existing: ParticleVector
idx=14 Derived: Base.RefValue{Any} Existing: Base.RefValue{NF}
idx=15 Derived: Clock Existing: Clock

Billy suggested to look at

Reactant.jl/src/Tracing.jl

Line 374 in d842b33

T = eltype(PT)

CC: @milankl

[giordano]

With (suggested by Billy)

diff --git a/src/Tracing.jl b/src/Tracing.jl
index 207968d1..845981d1 100644
--- a/src/Tracing.jl
+++ b/src/Tracing.jl
@@ -371,7 +371,7 @@ for P in (Ptr, Core.LLVMPtr, Base.RefValue)
         mode::TraceMode,
         @nospecialize(track_numbers::Type)
     )
-        T = eltype(PT)
+        T = PT.parameters[1]
         return $P{traced_type_inner(T, seen, mode, track_numbers)}
     end
 end

the error reduces to

Cannot convert type SpeedyWeather.RingGrids.GridGeometry{Grid}, best attempt SpeedyWeather.RingGrids.GridGeometry{Grid} failed.
This could be because the type does not capture the fieldtypes that should be converted in its type parameters.
idx=1 Derived: Int64 Existing: Int64
idx=2 Derived: Int64 Existing: Int64
idx=3 Derived: Int64 Existing: Int64
idx=4 Derived: ConcreteRArray{Float64, 1} Existing: Vector{Float64}
idx=5 Derived: ConcreteRArray{Float64, 1} Existing: Vector{Float64}
idx=6 Derived: Vector{UnitRange{Int64}} Existing: Vector{UnitRange{Int64}}
idx=7 Derived: ConcreteRArray{Int64, 1} Existing: Vector{Int64}
idx=8 Derived: ConcreteRArray{Float64, 1} Existing: Vector{Float64}

[wsmoses]

The latter error is due to the fact that SpeedyWeather.jl hardcodes a Vector{Float64} instead of a general type (such as a ConcreteRArray in our case).

see https://github.com/SpeedyWeather/SpeedyWeather.jl/blob/898f997c83f7c065b77164abe249d2b7fe233819/src/RingGrids/interpolation.jl#L7

cc @milankl @swilliamson7

[milankl]

Oh yeah we can change that to like field::VectorType with VectorType as a parameter of the struct? That's what we do in most other parts of the code but this guy seems to still have Vector harcoded

[wsmoses]

yeah that would fix