Skip to content

feat: ensure i32 indexing based on input sizes #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

feat: ensure i32 indexing based on input sizes #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions src/Ops.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2906,19 +2906,42 @@ end
]
end

function standardize_start_index(
sz::Int, start_index::Union{Integer,TracedRNumber{<:Integer}}
)
if (start_index isa Integer && start_index ≤ typemax(Int32)) || sz ≤ typemax(Int32)
start_index = Reactant.TracedUtils.promote_to(TracedRNumber{Int32}, start_index)
elseif start_index isa Integer
start_index = Reactant.TracedUtils.promote_to(
TracedRNumber{eltype(start_index)}, start_index
)
end

start_index = start_index - Reactant.unwrapped_eltype(start_index)(1)
return start_index
end

function standardize_start_indices(
operand::TracedRArray{T,N}, start_indices::Vector
) where {T,N}
@assert length(start_indices) == N
return [
standardize_start_index(size(operand, i), start_indices[i]).mlir_data for i in 1:N
]
end

@noinline function dynamic_update_slice(
operand::TracedRArray{T,N},
update::TracedRArray{T},
start_indices::Vector;
location=mlir_stacktrace("dynamic_update_slice", @__FILE__, @__LINE__),
) where {T,N}
start_indices = [
Reactant.TracedUtils.promote_to(TracedRNumber{Int32}, index - 1).mlir_data for
index in start_indices
]
res = MLIR.IR.result(
stablehlo.dynamic_update_slice(
operand.mlir_data, update.mlir_data, start_indices; location
operand.mlir_data,
update.mlir_data,
standardize_start_indices(operand, start_indices);
location,
),
1,
)
Expand All @@ -2931,15 +2954,10 @@ end
slice_sizes::Vector;
location=mlir_stacktrace("dynamic_slice", @__FILE__, @__LINE__),
) where {T,N}
start_indices = [
Reactant.TracedUtils.promote_to(
TracedRNumber{Int32}, index - Reactant.unwrapped_eltype(index)(1)
).mlir_data for index in start_indices
]
res = MLIR.IR.result(
stablehlo.dynamic_slice(
operand.mlir_data,
start_indices;
standardize_start_indices(operand, start_indices);
slice_sizes=collect(Int64, slice_sizes),
location,
),
Expand Down
Loading