Skip to content

Fix jl-generators for AttrSizedOperandSegments string #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2025
Merged

Fix jl-generators for AttrSizedOperandSegments string #1741

merged 1 commit into from
Oct 12, 2025

Conversation

@sbrantq
Copy link
Member

@sbrantq sbrantq commented Oct 10, 2025

It originally can produce something like

push!(attributes, operandsegmentsizes([length(inputs), 1, (mass==nothing) ? 0 : 1(step_size==nothing) ? 0 : 1(num_steps==nothing) ? 0 : 1]))

which lacks commas when I have optional MLIR operands like mass, step_size, and num_steps

@sbrantq sbrantq requested review from avik-pal and wsmoses October 10, 2025 20:04
@sbrantq sbrantq merged commit ff47542 into main Oct 12, 2025
9 of 11 checks passed
@sbrantq sbrantq deleted the fix-jl-generators branch October 12, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wsmoses wsmoses wsmoses approved these changes

@avik-pal avik-pal Awaiting requested review from avik-pal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbrantq @wsmoses