Skip to content

fix: TracedRNG path for correct create_result #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2025
Merged

fix: TracedRNG path for correct create_result #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Tracing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,7 +1901,7 @@ Base.@nospecializeinfer function make_tracer(
return make_tracer(seen, prev.seed, path, mode; kwargs...)
end
return ReactantRNG(
make_tracer(seen, prev.seed, (path..., :seed), mode; kwargs...), prev.algorithm
make_tracer(seen, prev.seed, (path..., 1), mode; kwargs...), prev.algorithm
)
end

Expand All @@ -1911,9 +1911,7 @@ Base.@nospecializeinfer function make_tracer(
if mode == ArrayToConcrete
TracedRandom.should_warn_if_not_natively_supported(prev)
return ReactantRNG(
make_tracer(
seen, TracedRandom.make_seed(prev), (path..., :seed), mode; kwargs...
),
make_tracer(seen, TracedRandom.make_seed(prev), (path..., 1), mode; kwargs...),
TracedRandom.rng_algorithm(prev),
)
end
Expand Down
10 changes: 10 additions & 0 deletions test/nn/lux.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,13 @@ end
res, ∂ps = @jit gradient_loss_function(model, x, ps, st)
@test res isa Reactant.ConcreteRNumber
end

@testset "RNG stored in state" begin
model = Dropout(0.5f0)
ps, st = Reactant.to_rarray(Lux.setup(Random.default_rng(), model))

x = Reactant.to_rarray(randn(Float32, 10, 10))

res, st_new = @jit model(x, ps, st)
@test st_new.rng isa Reactant.ReactantRNG
end
Loading