Skip to content

Conversation

@nhz2
Copy link
Contributor

@nhz2 nhz2 commented Nov 5, 2025

unzip_jll is no longer maintained, and p7zip_jll is a standard library.

@wsmoses wsmoses requested a review from giordano November 5, 2025 02:47
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 70.22%. Comparing base (b39a1fc) to head (3189e3d).
⚠️ Report is 133 commits behind head on main.

Files with missing lines Patch % Lines
src/accelerators/TPU.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1826      +/-   ##
==========================================
+ Coverage   68.16%   70.22%   +2.05%     
==========================================
  Files         109      114       +5     
  Lines       11779    13033    +1254     
==========================================
+ Hits         8029     9152    +1123     
- Misses       3750     3881     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avik-pal avik-pal merged commit b614095 into EnzymeAD:main Nov 5, 2025
69 of 70 checks passed
@nhz2 nhz2 deleted the switch-from-unzip-to-p7zip branch November 5, 2025 16:58
@nhz2
Copy link
Contributor Author

nhz2 commented Nov 7, 2025

It turns out that p7zip_jll has a bug on Linux JuliaLang/julia#60071

I tested, and the ".whl" files being extracted here do not trigger the problem, so I think it is okay to not revert this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants