Skip to content

Fix ReactantPythonCallExt.jl #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Fix ReactantPythonCallExt.jl #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9484922
Fix ReactantPythonCallExt.jl
wsmoses Dec 23, 2024
e891442
Apply suggestions from code review
wsmoses Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion ext/ReactantPythonCallExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,24 @@ using PythonCall

const jaxptr = Ref{Py}()

const NUMPY_SIMPLE_TYPES = (
("bool_", Bool),
("int8", Int8),
("int16", Int16),
("int32", Int32),
("int64", Int64),
("uint8", UInt8),
("uint16", UInt16),
("uint32", UInt32),
("uint64", UInt64),
("float16", Float16),
("float32", Float32),
("float64", Float64),
("complex32", ComplexF16),
("complex64", ComplexF32),
("complex128", ComplexF64),
)

function PythonCall.pycall(
f::Py, arg0::Reactant.TracedRArray, argNs::Reactant.TracedRArray...; kwargs...
)
Expand All @@ -16,7 +34,7 @@ function PythonCall.pycall(
inputs = map((arg0, argNs...)) do arg
JT = eltype(arg)
PT = nothing
for (CPT, CJT) in PythonCall.Convert.NUMPY_SIMPLE_TYPES
for (CPT, CJT) in NUMPY_SIMPLE_TYPES
if JT == CJT
PT = CPT
break
Expand Down
Loading