Skip to content

feat: more trigonometric functions #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2025
Merged

feat: more trigonometric functions #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e09a47d
feat: more trigonometric functions
avik-pal Jan 3, 2025
cbb333f
Update src/TracedRNumber.jl
avik-pal Jan 3, 2025
79e17cb
test: trig functions
avik-pal Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/TracedRNumber.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ for (jlop, hloop) in (
(:(Base.:-), :negate),
(:(Base.sin), :sine),
(:(Base.cos), :cosine),
(:(Base.tan), :tan),
(:(Base.tanh), :tanh),
(:(Base.FastMath.tanh_fast), :tanh),
(:(Base.exp), :exponential),
Expand All @@ -214,6 +215,13 @@ for (jlop, hloop) in (
@eval $(jlop)(@nospecialize(lhs::TracedRNumber)) = Ops.$(hloop)(lhs)
end

for (jlop, hloop) in
((:(Base.sinpi), :sine), (:(Base.cospi), :cosine), (:(Base.tanpi), :tan))
@eval $(jlop)(@nospecialize(lhs::TracedRNumber{T})) where {T} = Ops.$(hloop)(T(π) * lhs)
end

Base.sincospi(x::TracedRNumber{T}) where {T} = Ops.sine(T(π) * x), Ops.cosine(T(π) * x)

Base.conj(x::TracedRNumber) = x
Base.conj(x::TracedRNumber{<:Complex}) = Ops.conj(x)

Expand Down
25 changes: 25 additions & 0 deletions test/basic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,3 +885,28 @@ end
res = @jit fn(x_ra, Array(idxs_ra))
@test res ≈ fn(Array(x_ra), Array(idxs_ra))
end

@testset "Common Trig Functions" begin
x = rand(Float32, 4, 16)
x_ra = Reactant.to_rarray(x)

@testset for fn in (sinpi, cospi, tanpi, sin, cos, tan)
@test @jit(fn.(x_ra)) ≈ fn.(x)
@test @jit(fn.(x_ra)) isa ConcreteRArray{Float32,2}
end

x = 0.235f0
x_ra = Reactant.to_rarray(x; track_numbers=(Number,))

@testset for fn in (sinpi, cospi, tanpi, sin, cos, tan)
@test @jit(fn.(x_ra)) ≈ fn.(x)
@test @jit(fn.(x_ra)) isa ConcreteRNumber{Float32}
end
@testset for fn in (sincospi, sincos)
res = @jit fn(x_ra)
@test res[1] ≈ fn(x)[1]
@test res[2] ≈ fn(x)[2]
@test res[1] isa ConcreteRNumber{Float32}
@test res[2] isa ConcreteRNumber{Float32}
end
end
Loading