Skip to content

feat: missing mean(f, ...) dispatches #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2025
Merged

feat: missing mean(f, ...) dispatches #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4343f3
feat: missing mean(f, ...) dispatches
avik-pal Jan 5, 2025
a01e73a
Update ext/ReactantStatisticsExt.jl
avik-pal Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions ext/ReactantStatisticsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,22 @@ using Reactant: AnyTracedRArray
using Reactant.TracedUtils: materialize_traced_array
using Statistics: Statistics

function Statistics.mean(A::AnyTracedRArray{T,N}; dims=:) where {T,N}
A = materialize_traced_array(A)
function Statistics._mean(f::F, A::AnyTracedRArray{T,N}, dims) where {F,T,N}
denom = dims isa Colon ? length(A) : prod(Base.Fix1(size, A), dims)
return mapreduce(identity, +, A; dims) / denom
return mapreduce(f, +, A; dims) / denom
end

function Statistics.var(
A::AnyTracedRArray{T,N}; dims=:, mean=nothing, corrected=true
function Statistics._var(
A::AnyTracedRArray{T,N}, corrected::Bool, mean, ::Colon
) where {T,N}
A = materialize_traced_array(A)
mean === nothing && (mean = Statistics.mean(A))
denom = length(A) - corrected
return mapreduce(abs2, +, A .- mean; dims=:) / denom
end

function Statistics._var(A::AnyTracedRArray{T,N}, corrected::Bool, mean, dims) where {T,N}
mean === nothing && (mean = Statistics.mean(A; dims))
denom = (dims isa Colon ? length(A) : prod(Base.Fix1(size, A), dims)) - corrected
denom = prod(Base.Fix1(size, A), dims) - corrected
return mapreduce(abs2, +, A .- mean; dims) / denom
end

Expand Down
6 changes: 6 additions & 0 deletions test/basic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,22 @@ end
mean_fn2(x) = mean(x; dims=1)
mean_fn3(x) = mean(x; dims=(1, 2))
mean_fn4(x) = mean(x; dims=(1, 3))
mean_f1abs2(x) = mean(abs2, x)
mean_f2abs2(x) = mean(abs2, x; dims=1)

mean_fn1_compiled = @compile mean_fn1(x_ca)
mean_fn2_compiled = @compile mean_fn2(x_ca)
mean_fn3_compiled = @compile mean_fn3(x_ca)
mean_fn4_compiled = @compile mean_fn4(x_ca)
mean_f1abs2_compiled = @compile mean_f1abs2(x_ca)
mean_f2abs2_compiled = @compile mean_f2abs2(x_ca)

@test mean_fn1(x) ≈ mean_fn1_compiled(x_ca)
@test mean_fn2(x) ≈ mean_fn2_compiled(x_ca)
@test mean_fn3(x) ≈ mean_fn3_compiled(x_ca)
@test mean_fn4(x) ≈ mean_fn4_compiled(x_ca)
@test mean_f1abs2(x) ≈ mean_f1abs2_compiled(x_ca)
@test mean_f2abs2(x) ≈ mean_f2abs2_compiled(x_ca)

# XXX: @jit doesn't work with `;`
# @test @jit(var(x_ca)) ≈ var(x)
Expand Down
Loading