-
Notifications
You must be signed in to change notification settings - Fork 33
linearize aliased kernel args #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| argidx - 1, | ||
| 0, | ||
| C_NULL, | ||
| ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I moved argidx++ out of the loop, I'm not sure whether this is still correct because I don't really know what's happening here.
|
@jumerckx to make review easier, can you rebase this on main? |
3a92b96 to
6b96fea
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test with the repeated arg, otherwise lgtm
6b96fea to
f8bd69a
Compare
|
@jumerckx can you add that as a test, then let's merge! |
|
I'm afk til tomorrow but will add it then. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
LGTM but I think there's a conflict that needs to be fixed to merge |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Can't test end-to-end but the HLO contains the stores.