Skip to content

Implement isnan and isfinite for TracedRNumber #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Implement isnan and isfinite for TracedRNumber #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c26257
Implement `isnan` for TracedRNumber
Pangoraw Jan 13, 2025
5b2c66a
isfinite and complex
Pangoraw Jan 13, 2025
02fce1d
update
Pangoraw Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/TracedRNumber.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,20 @@ function Base.eps(::Type{TracedRNumber{T}}) where {T}
return TracedUtils.promote_to(TracedRNumber{T}, eps(T))
end

function Base.isfinite(x::TracedRNumber{<:Complex})
return isfinite(real(x)) & isfinite(imag(x))
end
function Base.isfinite(x::TracedRNumber{T}) where {T<:AbstractFloat}
return Reactant.Ops.is_finite(x)
end

function Base.isnan(x::TracedRNumber{T}) where {T<:AbstractFloat}
return !isfinite(x) & (x != typemax(T)) & (x != typemin(T))
end
function Base.isnan(x::TracedRNumber{<:Complex})
return isnan(real(x)) | isnan(imag(x))
end

function Base.show(io::IOty, X::TracedRNumber{T}) where {T,IOty<:Union{IO,IOContext}}
return print(io, "TracedRNumber{", T, "}(", X.paths, ")")
end
Expand Down
28 changes: 22 additions & 6 deletions test/basic.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,26 +371,26 @@ end

@testset "Number and RArray" for a in [1.0f0, 1.0e0]
typeof_a = typeof(a)
_b = [2.0, 3.0, 4.0] .|> typeof_a
_c = [2.0 3.0 4.0] .|> typeof_a
_b = typeof_a.([2.0, 3.0, 4.0])
_c = typeof_a.([2.0 3.0 4.0])
b = Reactant.to_rarray(_b)
c = Reactant.to_rarray(_c)

# vcat test
y = @jit vcat(a, b)
@test y == vcat(a, _b)
@test y isa ConcreteRArray{typeof_a,1}

## vcat test - adjoint
y1 = @jit vcat(a, c')
@test y1 == vcat(a, _c')
@test y1 isa ConcreteRArray{typeof_a,2}

# hcat test
z = @jit hcat(a, c)
@test z == hcat(a, _c)
@test z isa ConcreteRArray{typeof_a,2}

## hcat test - adjoint
z1 = @jit hcat(a, b')
@test z1 == hcat(a, _b')
Expand Down Expand Up @@ -1028,3 +1028,19 @@ end
@test res[2] isa ConcreteRNumber{Float32}
end
end

@testset "isfinite" begin
x = Reactant.to_rarray([1.0, NaN, Inf, -Inf, NaN])
@test Reactant.@jit(isfinite.(x)) == [true, false, false, false, false]

x = Reactant.to_rarray([1.0, NaN, Inf, -Inf, NaN] .* im)
@test Reactant.@jit(isfinite.(x)) == [true, false, false, false, false]
end

@testset "isnan" begin
x = Reactant.to_rarray([1.0, NaN, Inf, -Inf, NaN])
@test Reactant.@jit(isnan.(x)) == [false, true, false, false, true]

x = Reactant.to_rarray([1.0, NaN, Inf, -Inf, NaN] .* im)
@test Reactant.@jit(isnan.(x)) == [false, true, false, false, true]
end
Loading