Skip to content

Fix condition to skip CUDA tests on aarch64 #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix condition to skip CUDA tests on aarch64 #592

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3137585
Fix condition to skip CUDA tests on aarch64
giordano Jan 21, 2025
3d88d09
Skip more tests
giordano Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions test/integration/cuda.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ end
# GPUCompiler throws "Not implemented" errors on aarch64 before
# <https://github.com/JuliaLang/julia/pull/57077> for some tests.
const skip_tests =
Base.BinaryPlatforms.arch(Base.BinaryPlatforms.HostPlatform()) == "aarch" &&
VERSION <= v"1.11.2"
Base.BinaryPlatforms.arch(Base.BinaryPlatforms.HostPlatform()) == "aarch64" &&
VERSION <= v"1.11.3"

@static if !Sys.isapple()
@testset "Square Kernel" begin
Expand Down Expand Up @@ -126,7 +126,9 @@ tuplef2(a) = @cuda threads = 1 tuplef2!((5, a))
@jit tuplef2(A)
@test all(Array(A) .≈ 5)
else
@code_hlo optimize = :before_kernel tuplef2(A)
@static if !skip_tests
@code_hlo optimize = :before_kernel tuplef2(A)
end
end
end
A = ConcreteRArray(fill(1))
Expand Down Expand Up @@ -162,7 +164,9 @@ end
@jit aliased(a)
@test all(Array(a) .== 9)
else
@code_hlo optimize = :before_kernel aliased(a)
@static if !skip_tests
@code_hlo optimize = :before_kernel aliased(a)
end
end
end
end
Expand Down
Loading