Skip to content

Replace trim -> strip #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

Replace trim -> strip #661

merged 1 commit into from
Jan 30, 2025

Conversation

@giordano
Copy link
Member

There's no trim function in Julia Base.

@giordano
Replace trim -> strip
54146bd 
There's no `trim` function in Julia `Base`.
@giordano giordano requested a review from Pangoraw January 30, 2025 12:31
Pangoraw
Pangoraw approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@Pangoraw Pangoraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@Pangoraw Pangoraw merged commit a2da11b into EnzymeAD:main Jan 30, 2025
34 of 38 checks passed
@giordano giordano deleted the mg/strip-trim branch January 30, 2025 12:46
@glou-nes glou-nes mentioned this pull request Mar 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pangoraw Pangoraw Pangoraw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giordano @Pangoraw