Regenerate MLIR Bindings #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofeing
approved these changes
Feb 2, 2025
|
This breaks documentation |
|
@mofeing you need to add MPI to the list of dialects in the docs section. also relatedly, you probably need to make sure we load the dialect in the right places before we can use it |
|
For the docs, I presume you need to do something like #648 |
|
okay, i think docs should be fixed now
yeah, but will leave it for another PR |
|
docs have been fixed, initialization of the MPI will be done in a posterior PR once we add support for MPI and the failing tests are due to other problems, so i'm merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action