feat: API changes for multi-device execution [ReactantExtra JLL changes]

[avik-pal]

No description provided.

[giordano]

Looks OK for as much as I can tell (which is limited 😅).

still debugging 1 segfault from the finalizer

Was that solved? I don't see new commits after that message.

[avik-pal]

Actually wait no not solved. I thought it got fixed... But it does segfault on finalizer. Let me investigate under gdb and hope it reveals more info

[wsmoses]

Not a segfault source but I do see a memory error.

For example: here we allocate memory

Reactant.jl/deps/ReactantExtra/API.cpp

Line 394 in d842b33

return cstr_from_string(client->platform_name());

and when using it

Reactant.jl/src/XLA.jl

Line 625 in d842b33

str = @ccall MLIR.API.mlir_c.ClientGetPlatformName(

I don't think we ever free it (we need to do unsafe_string, and then free the memory).

[avik-pal]

We can go ahead with this JLL. Turns out I don't understand basic arithmetic 😢