Add GPUCompiler and LLVM as deps to CUDA extension and run CUDA tests on macOS #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
approved these changes
Feb 6, 2025
giordano
force-pushed
the
mg/cuda-tests-macos
branch
from
049d305 to
52f8b0e
Compare
giordano
force-pushed
the
mg/cuda-tests-macos
branch
from
5296b4e to
42b4b10
Compare
wsmoses
reviewed
Feb 7, 2025
| EnzymeCore = "0.8.8" | ||
| Functors = "0.5" | ||
| GPUArraysCore = "0.1.6, 0.2" | ||
| GPUArraysCore = "0.2" |
There was a problem hiding this comment.
Sorry going back to this, I'm worried that the very late GPUCompiler will cause issues for Oceananigans which is presently stuck at a lower version.
Obviously this is needed for CPU execution, but we could also consider lowering
There was a problem hiding this comment.
I think CliMA/Oceananigans.jl#4081 should help?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
GPUCompiler@v1.1.1we can run CUDA integration tests also on macOS, I verified locally (on aarch64-darwin) that these tests now are successfully.