change retrofit api complete #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. в useCase перенесена ссылка репозиторий, чтобы презентор работал не через репозитрий напрямую а через useCase
…ределил binding по красоте, ViewModelMvvm.kt теперь сама обрабатывет запросы из UseCaseGetPosts.kt, ViewModelMvvm.kt, наследуется от ViewModel, обнавлен MvvmContract.kt чтобы фрагмент не мог изменять LiveData
seprjezu
reviewed
Feb 13, 2021
| override val errorMessage: MutableLiveData<Throwable> = MutableLiveData() | ||
|
|
||
| override fun getPosts() { | ||
| viewModelScope.launch(Dispatchers.IO) { |
There was a problem hiding this comment.
По гайдлайнам писать саспенд функции надо таким образом, чтобы они не блокировали вызывающий поток. В Retrofit это реализовано, поэтому переключать на IO нет смысла
|
|
||
| override fun getPosts() { | ||
| viewModelScope.launch(Dispatchers.IO) { | ||
| try { |
There was a problem hiding this comment.
в качестве улучшения, можешь попробовать ловить ошибки глобальным обработчиком ошибок
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.