перевод на Mvvm #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. в useCase перенесена ссылка репозиторий, чтобы презентор работал не через репозитрий напрямую а через useCase
seprjezu
reviewed
Jan 10, 2021
|
|
||
| interface MvvmContract { | ||
|
|
||
| val listPosts: MutableLiveData<List<Post>> |
There was a problem hiding this comment.
лучше наружу выводить LiveData а не мутабельную. Вью не должна ничего постить во вьюмодель
|
|
||
| private val repository: IRepository = Repository() | ||
|
|
||
| fun loadPosts(listPosts: MutableLiveData<List<Post>>, errorMessage: MutableLiveData<Throwable>) { |
There was a problem hiding this comment.
лучше не нагружать юзкейс ещё логикой передачи данных во вьюмодель. Лучше просто получат их из источника и сортирует, а про то как их передать на вью, лучше пусть думает вьюмодель
seprjezu
suggested changes
Jan 10, 2021
| import com.example.architecturebase.UseCases.UseCaseGetPosts | ||
| import com.example.architecturebase.network.model.Post | ||
|
|
||
| class ViewModelMvvm : LifecycleObserver, MvvmContract { |
There was a problem hiding this comment.
нужно отнаследоваться именно от ViewModel от google
…ределил binding по красоте, ViewModelMvvm.kt теперь сама обрабатывет запросы из UseCaseGetPosts.kt, ViewModelMvvm.kt, наследуется от ViewModel, обнавлен MvvmContract.kt чтобы фрагмент не мог изменять LiveData
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.