Skip to content

Conversation

@dbukki
Copy link
Collaborator

@dbukki dbukki commented Sep 30, 2023

The issue originally mentions only workspaces not being in the correct order. But I noticed that root files in the file browser pane were also not ordered, and the fix is very similar in both cases (missing std::sort).

Fixes #626.

@intjftw
Copy link
Collaborator

intjftw commented Sep 30, 2023

@dbukki Can you please link the corresponding issue? Writing "Fixes #" will automatically link it.

@dbukki
Copy link
Collaborator Author

dbukki commented Sep 30, 2023

Fixes #626

@mcserep
Copy link
Collaborator

mcserep commented Sep 30, 2023

Fixes #626

You have to place that into the initial PR description to make it work, I have updated it.

@mcserep mcserep requested review from intjftw and mcserep September 30, 2023 13:29
@mcserep mcserep added this to the Release Gershwin milestone Sep 30, 2023
Copy link
Collaborator

@mcserep mcserep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@mcserep mcserep merged commit 7adf083 into Ericsson:master Oct 1, 2023
@dbukki dbukki deleted the name-order branch October 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind: Enhancement 🌟 Target: Service Issues related to the Thrift service.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort projects alphabetically

3 participants