This repository was archived by the owner on Mar 30, 2021. It is now read-only.
Clang and llvm Revision/repository now can be specified as a compilation flag. #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flag. Alongside the existing -DSVN_REVISION flag, (which specifies the clang revision number) now there are three more flag that can be specified when there are no revision info in the clang/llvm source directory. -DSVN_REPOSITORY=<url> specifies clang repository. -DLLVM_REVISION=<revno> specifies llvm revision. -DLLVM_REPOSITORY=<url> specigies llvm repositiory.
Member
|
Can one of the admins verify this patch? |
Collaborator
|
Why not |
|
run tests |
martong
approved these changes
Aug 23, 2018
martong
left a comment
martong
left a comment
There was a problem hiding this comment.
LGTM. But please wait for the PR build hook.
Author
|
The three new added define, is already being used in Version.cpp. I think this was the smallest possible intrusion to the existing codebase. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alongside the existing -DSVN_REVISION flag, (which specifies the clang revision
number) now there are three more flag that can be specified when there are
no revision info in the clang/llvm source directory.
-DSVN_REPOSITORY= specifies clang repository.
-DLLVM_REVISION= specifies llvm revision.
-DLLVM_REPOSITORY= specigies llvm repositiory.