Stop manage init/systemd and start scripts #122
Conversation
That makes sense since the architect (who provided these scripts) had to leave the company some years (?) ago. |
|
Looks good to me. Please add the tests for Puppet 8 and I think we are good to go. |
|
This one is currently being tested. Don't merge it for now. |
|
Hmm btw @Phil-Friderici . Should this be a feature or a major release? It does change the behaviour quite a bit. |
Phil-Friderici
left a comment
Phil-Friderici
left a comment
There was a problem hiding this comment.
code looks good to me, although I didn't actually test it.
anders-larsson
force-pushed
the
stop_manage_startscript
branch
from
8b285b4 to
70b3bb4
Compare
This should definitly be a new major version! |
|
Anything else we want to get in while we're making a major release? |
|
Remove Solaris support? It hasn't been used, by us, for quite a while. Not sure if it actually works any more. Well I guess nothing has changed in Solaris land so it ought to still work :D |
This is no longer needed. Better to provide correct start scripts in the package itself instead of managing it with Puppet.
anders-larsson
force-pushed
the
stop_manage_startscript
branch
from
70b3bb4 to
4a1147c
Compare
|
Well, I guess removing support for Solaris can reduce code and maintanance efforts a little bit. Why not remove it. Could be readded whenever needed again. |
|
OK. Will make a PR to remove Solaris. Something I don't understand. Git a dependency cycle when I tried the module i practice for cron file. It does not happen n spec tests. I fixed the issue. |
It was decided that this is no longer needed. It was something that was added a long time ago. It's better use the already included scripts (which are more updated now) than the ones provided in the module.
This should also makes it easier for others to use this module if they wish.
Based on PR #121 that should be merged before this one.