Update to latest upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Improved test_subscription_options Signed-off-by: ahcorde <ahcorde@gmail.com> * used RCLCPP_EXPECT_THROW_EQ in test_subcription_options Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
* Covered resolve_use_intra_process Signed-off-by: ahcorde <ahcorde@gmail.com> * used RCLCPP_EXPECT_THROW_EQ in test_subscription_throws_intraprocess Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Make sure to #include what is used, and also fix a typo in a test. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This gets us to 96% line coverage. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Add missing tests API * Reformat style error throw * Add internal errors tests Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Change value used as max representation * Add coverage tests time * Add call to detach clock * Add tests time * Add duration construction tests * Add const qualifier to constants * Add check clock stays the same * Make operator RCLCPP_PUBLIC * Add tests exceptions duration * Fix division by 0 on windows Signed-off-by: Jorge Perez <jjperez@ekumenlabs.com>
* Add test for ParameterService Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR feedback Signed-off-by: Stephen Brawner <brawner@gmail.com>
In particular, add API coverage for spin_node_until_future_complete, spin_until_future_complete, and spin_node_once. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add unit tests for qos and qos_event files Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address PR Feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix windows CI Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Increase coverage of WaitSetTemplate Signed-off-by: Stephen Brawner <brawner@gmail.com> * PR fixup Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
…1333) Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
… dependency (#1303) * Clear members for StaticExecutorEntitiesCollector to avoid shared_ptr dependency Signed-off-by: Chen Lihui <Lihui.Chen@sony.com> Signed-off-by: Chris Lalancette <clalancette@openrobotics.org> Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Audrow Nash <audrow.nash@gmail.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
…#1411) * Initial benchmark tests for rclcpp::init/shutdown create/destroy node Signed-off-by: Stephen Brawner <brawner@gmail.com> * Pr feedback Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fixes to cmakelists Signed-off-by: Stephen Brawner <brawner@gmail.com> * Remove quotes Signed-off-by: Stephen Brawner <brawner@gmail.com> * Move find_package calls Signed-off-by: Stephen Brawner <brawner@gmail.com> * Skip create/destroy node for rmw_connext_cpp Signed-off-by: Stephen Brawner <brawner@gmail.com> * SKIP TEST in cmakelists Signed-off-by: Stephen Brawner <brawner@gmail.com> * Add warmup loops Signed-off-by: Stephen Brawner <brawner@gmail.com> * remove for loop Signed-off-by: Stephen Brawner <brawner@gmail.com> * reset_heap_counters Signed-off-by: Stephen Brawner <brawner@gmail.com> * Change to make_shared Signed-off-by: Stephen Brawner <brawner@gmail.com>
This patch actually does 4 related things: 1. Renames the recursive mutex in the ServerBaseImpl class to action_server_reentrant_mutex_, which makes it a lot clearer what it is meant to lock. 2. Adds some additional error checking where checks were missed. 3. Adds a lock to publish_status so that the action_server structure is protected. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
* Set CMakeLists to only use default rmw for benchmarks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Add comment Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Add service and client benchmarks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Style Signed-off-by: Stephen Brawner <brawner@gmail.com> * Uncrustify Signed-off-by: Stephen Brawner <brawner@gmail.com>
* Benchmark rclcpp_action action_client Signed-off-by: Stephen Brawner <brawner@gmail.com> * Bump timeout Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Chen Lihui <Lihui.Chen@sony.com>
…rom ROS 1 (#1432) * Deprecate Duration(rcl_duration_value_t) in favor of static Duration::from_nanoseconds(rcl_duration_value_t) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Older versions of MSVC 2019 can't figure out the correct namespace. Just to keep them happy, add a fully-qualified namespace. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Added executor benchmark tests Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * initialize callback_count Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feddback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feedback Signed-off-by: ahcorde <ahcorde@gmail.com> * Added add_node and remove_node benchmark tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Add/remove node in static_single_thread_executor Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Added StaticSingleThreadedExecutor add/remove node tests Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
* Add rclcpp_action action_server benchmarks Signed-off-by: Stephen Brawner <brawner@gmail.com> * Address cancel bug Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix errors Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix clang error Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Refactor graph listener tests to work on CentOS. inject_on_return doesn't work on CentOS. To fix this, we do two separate things: 1. Where applicable, replace calls to inject_on_return with patch_and_return (which does work). 2. We were sort of abusing inject_on_return to do partial initialization for us for some of the tests. Instead, make the class under test (GraphListener) have a protected method that we can call to do initialization. With this in place, we can now get rid of the problematic inject_on_return. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
* Remove allocation from remove_node Signed-off-by: Stephen Brawner <brawner@gmail.com> * Fix uncrustify Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Scott K Logan <logans@cottsay.net>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
* Change uint8_t iterator variables to size_t Signed-off-by: Stephen Brawner <brawner@gmail.com> * Change to unsigned int Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
#1404) Signed-off-by: Stephen Brawner <brawner@gmail.com>
…rs (#1464) * Reserve vector capacities and use emplace_back for constructing vectors Signed-off-by: Stephen Brawner <brawner@gmail.com> * Use resize instead of reserve Signed-off-by: Stephen Brawner <brawner@gmail.com> * Remove push_back Signed-off-by: Stephen Brawner <brawner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating fork with latest upstream changes.