Skip to content

Conversation

@BochaberiDaisy
Copy link
Contributor

Fix: #46

@hhkaos, please review the PR.

Features added:

  • Increased the height of the body and description fields using Calcite.
  • Added checkboxes to select language snippet scopes
  • Implemented a "Copy to Clipboard" button.
  • Introduced a button to import snippets.

@hhkaos
Copy link
Member

hhkaos commented Oct 15, 2024

thanks @BochaberiDaisy ! I'll check it later today 😄

@BochaberiDaisy
Copy link
Contributor Author

Okay. I'll appreciate the feedback 😀

Copy link
Member

@hhkaos hhkaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BochaberiDaisy ! it's looking pretty good, but I noticed some things are not properly working. Could you check these?

bugs.mp4

Thanks again! I really appreciate your time. You are doing it very good

builder/main.js Outdated
const snippetObject = JSON.parse(fileContent);

const snippetDisplay = document.getElementById("snippets");
snippetDisplay.innerText = JSON.stringify(snippetObject, null, 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, I'm just missing the form to be filled too:
2024-10-16_16-08-29

</calcite-popover-manager>
</span>

<input type="file" id="import-snippet" accept=".json">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind using the <calcite-input type="file" ...>? (doc here)
Screenshot 2024-10-16 at 16 22 35

For UX purposes, could could add a sample file, just in case; maybe a sample.json with something like this:

{
  "A JavaScript only snippet": {
      "scope": "javascript",
      "prefix": "myConsoleLog",
      "body": [
          "console.log(\"Hello Map\");"
      ],
      "description": "Console log \"Hello Map\""
  }
}

@BochaberiDaisy
Copy link
Contributor Author

@hhkaos, thank you for the feedback. Let me work on the changes and share.

@hhkaos
Copy link
Member

hhkaos commented Oct 17, 2024

Sure @BochaberiDaisy ! let me know if you need any additional help 😄

Copy link
Member

@hhkaos hhkaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @BochaberiDaisy! 👏

@hhkaos hhkaos merged commit 871d569 into Esri:master Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance snippets builder

2 participants