-
Notifications
You must be signed in to change notification settings - Fork 16
feat: Enhance Snippet Builder #46 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance Snippet Builder #46 #57
Conversation
|
thanks @BochaberiDaisy ! I'll check it later today 😄 |
|
Okay. I'll appreciate the feedback 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BochaberiDaisy ! it's looking pretty good, but I noticed some things are not properly working. Could you check these?
bugs.mp4
Thanks again! I really appreciate your time. You are doing it very good
builder/main.js
Outdated
| const snippetObject = JSON.parse(fileContent); | ||
|
|
||
| const snippetDisplay = document.getElementById("snippets"); | ||
| snippetDisplay.innerText = JSON.stringify(snippetObject, null, 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
builder/index.html
Outdated
| </calcite-popover-manager> | ||
| </span> | ||
|
|
||
| <input type="file" id="import-snippet" accept=".json"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind using the <calcite-input type="file" ...>? (doc here)

For UX purposes, could could add a sample file, just in case; maybe a sample.json with something like this:
{
"A JavaScript only snippet": {
"scope": "javascript",
"prefix": "myConsoleLog",
"body": [
"console.log(\"Hello Map\");"
],
"description": "Console log \"Hello Map\""
}
}|
@hhkaos, thank you for the feedback. Let me work on the changes and share. |
|
Sure @BochaberiDaisy ! let me know if you need any additional help 😄 |
hhkaos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work @BochaberiDaisy! 👏

Fix: #46
@hhkaos, please review the PR.
Features added: