GH-1210 Add placeholder documentation automation. #1210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an excellent feature for automating placeholder documentation using annotations. The refactoring in AfkPlaceholderSetup to use the new @PlaceholderDocs annotation is a great improvement for maintainability and clarity. The new API for scanning and resolving these annotations is well-designed. I have a couple of suggestions to further improve the code quality by addressing a minor code clarity issue and some code duplication.
...ore-core/src/main/java/com/eternalcode/core/feature/afk/placeholder/AfkPlaceholderSetup.java
Outdated
Show resolved
Hide resolved
eternalcore-docs-generate/src/main/java/com/eternalcode/annotations/scan/GenerateDocs.java
Show resolved
Hide resolved
P1otrulla
reviewed
Oct 17, 2025
...ore-core/src/main/java/com/eternalcode/core/feature/afk/placeholder/AfkPlaceholderSetup.java
Show resolved
Hide resolved
CitralFlo
requested changes
Oct 17, 2025
Member
CitralFlo
left a comment
CitralFlo
left a comment
There was a problem hiding this comment.
Rollczi: dodatkowe review w commit wip. ogólnie spoko
eternalcore-docs-generate/src/main/java/com/eternalcode/annotations/scan/GenerateDocs.java
Outdated
Show resolved
Hide resolved
eternalcore-core/src/main/java/com/eternalcode/core/feature/home/HomePlaceholderSetup.java
Show resolved
Hide resolved
Jakubk15
changed the title
Jakubk15
approved these changes
Oct 18, 2025
imDMK
reviewed
Oct 19, 2025
|
|
||
| @Override | ||
| public PlaceholderResult resolve(EternalScanRecord record, PlaceholderDocs annotation) { | ||
| String prefixedName = "%eternalcore_" + annotation.name() + "%"; |
Contributor
There was a problem hiding this comment.
Suggested change
| String prefixedName = "%eternalcore_" + annotation.name() + "%"; | |
| String prefix = "%eternalcore_" + annotation.name() + "%"; |
| public PlaceholderResult resolve(EternalScanRecord record, PlaceholderDocs annotation) { | ||
| String prefixedName = "%eternalcore_" + annotation.name() + "%"; | ||
| return new PlaceholderResult( | ||
| prefixedName, |
Contributor
There was a problem hiding this comment.
Suggested change
| prefixedName, | |
| prefix, |
P1otrulla
approved these changes
Oct 19, 2025
CitralFlo
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1209