Skip to content

fix: Ork fleet behaviour tweaks #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2024
Merged

fix: Ork fleet behaviour tweaks #129

merged 1 commit into from
Nov 17, 2024

Conversation

@OH296
Copy link

@OH296 OH296 commented Nov 16, 2024 •
edited
Loading

  • ork behaviour changes mostly to stop the infinite fleet creation problem
    • ork fleets will now crash land again as intended
    • all ork fleets will automatically move if they haven't moved fo 15 turns
    • ork fleets will now merge when at the same location hopefully restricting runaway number of fleets
  • added a turns_static marker for all fleets incrementing for every turn a fleet does not move
    • this does not break saving as it will just default to 0 for old saves
  • deprecated lots of instances of instance_exists(orbiting) for is_orbiting()
  • create generic merge fleets function (will need expanding as currently only really works for ork fleets)

@github-actions github-actions bot added the PR: Feature Adds something new label Nov 16, 2024
@EttyKitty EttyKitty added PR: Fix This is a fix for a bug PR: Refactor Rewriting/restructuring code, while keeping general behaviour PR: Performance Refactor that improves performance PR: Major Coding Big enough to possibly clash with other PRs and removed PR: Feature Adds something new labels Nov 17, 2024
@EttyKitty EttyKitty changed the title ork behaviour tweaks fix: Ork fleet behaviour tweaks Nov 17, 2024
@EttyKitty EttyKitty merged commit 59933d6 into EttyKitty:compile/main Nov 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Fix This is a fix for a bug PR: Major Coding Big enough to possibly clash with other PRs PR: Performance Refactor that improves performance PR: Refactor Rewriting/restructuring code, while keeping general behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OH296 @EttyKitty