Skip to content

refactor: Default max kills at 1 and minor code clarity #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

refactor: Default max kills at 1 and minor code clarity #154

merged 1 commit into from
Nov 25, 2024

Conversation

@EttyKitty
Copy link
Owner

@EttyKitty EttyKitty commented Nov 20, 2024 •
edited
Loading

  • Always display max kills at 1 for weapons.
  • 2D array for item properties and defaults.
  • Minor changes to splash code.

@EttyKitty EttyKitty added PR: Refactor Rewriting/restructuring code, while keeping general behaviour PR: Misc Change A change with no distinct category labels Nov 21, 2024
OH296
OH296 suggested changes Nov 22, 2024
View reviewed changes
Copy link

@OH296 OH296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would recommend cherry picking this onto 0.10.0 as the weapon strut is now being stored in it's own script separate from the weapon data

@EttyKitty EttyKitty merged commit 3a32a28 into compile/main Nov 25, 2024
1 check passed
@EttyKitty EttyKitty deleted the pr/item-defaults branch November 25, 2024 18:43
@EttyKitty EttyKitty added PR: Fix This is a fix for a bug and removed PR: Misc Change A change with no distinct category labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@OH296 OH296 OH296 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: Fix This is a fix for a bug PR: Refactor Rewriting/restructuring code, while keeping general behaviour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EttyKitty @OH296