Skip to content

Conversation

@Blogaugis
Copy link

Bombardment fixes:
Should make some factions more resistant to bombardments, some less, more or less based on their behavior in the universe. Also flavor tweaks.

Bombardment fixes:
Should make some factions more resistant to bombardments, some less, more or less based on their behavior in the universe.
Also flavor tweaks.
Copy link

@OH296 OH296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address points in order to merge

Adds TODOs, and some commented out potentially useful code in the future.
@EttyKitty
Copy link
Owner

do I consider this pr to be completed? no more questions or additions?

@Blogaugis
Copy link
Author

I guess this is more or less it, I added some more TODO comments, otherwise I think it is ready to be merged, unless any1 finds more issues?

I'm not sure how to go with more variation though. In general - yes, I should try to make more flavor text about different types of planets and other things that player does, but the 'Point of View' questions remain.

@EttyKitty EttyKitty force-pushed the compile/main branch 3 times, most recently from 4363e18 to 089eb23 Compare October 24, 2024 22:32
Updated TODO comments.
Blogaugis and others added 4 commits November 5, 2024 20:52
Fixes the possible error of bombardment overwriting protection.
Replacing extreme losses with total annihilation.
Removal of excess word 'population'.
@EttyKitty EttyKitty requested a review from OH296 November 5, 2024 19:57
EttyKitty
EttyKitty previously approved these changes Nov 6, 2024
txt2="##The Ork forces are well dug in; ";
bombard_protection=2;
txt2="##The Ork forces are poorly dug in; ";
bombard_protection=1; // I think they shouldn't be so resistant to it, though, Ideally we might want to make them more capable, if warboss is present.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be step in the direction away from the objective of making bombard less of an auto use feature?

Copy link
Author

@Blogaugis Blogaugis Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I don't think it is that extreme, that it affects the game much.
I think ideally orks should be stronger if they have leaders in the location, like big mek (building contraptions, perhaps StOs too), weirdboy (Waaagh energy shenanigans) or warboss (higher effectiveness in general).
Otherwise, they should be mostly treated as feral orks, without effective leadership.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rough idea is this, in terms of protection level:
1 - Feral, leaderless orks;
2 - Orks that have joined the warboss, but don't have a notable leader present;
3 - Orks have a leader (big mek, weirdboy or warboss) present;
4 - Orks have several or all the leaders in the location. Truly a proper WAAAGH.

Copy link

@OH296 OH296 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quantifiably it does have an effect. And that quantifiable effect is all i really care about in this statement. Wish listing components that aren't there. Mathematically speaking the difference is the difference between a 70-90% chance of strength reductions per bombardment with a miner fleet and a 50-60% percent. it's also the difference between a battle barge and a handful of frigates clearing a planet completely in from level 5 by one level and two levels which in terms of gameplay and the dynamics of arriving at a system of 4 planets full of orks is a huge difference. Dubbing Yes, but I don't think it is that extreme without provision of any of the maths leads me to believe the maths is not considered with choices made. And i can't really accept an argument that the balance isn't that good to begin with. Bad balance is precisely the reason to not keep making an issue worse

Copy link
Owner

@EttyKitty EttyKitty Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blogaugis, just revert that protection on Orks and let's merge this already.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, if you say so.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Let me know if you are okay with this little text tweak or want to revert that back to the dry description again.

Blogaugis and others added 2 commits November 7, 2024 14:00
Removing excess TODOs.

Co-authored-by: Nelsonh <81228864+OH296@users.noreply.github.com>
Implementing suggestion.

Co-authored-by: Nelsonh <81228864+OH296@users.noreply.github.com>
@EttyKitty EttyKitty added PR: Enhancement Makes something better PR: Refactor Rewriting/restructuring code, while keeping general behaviour PR: Misc Change A change with no distinct category PR: Balance labels Nov 8, 2024
Revert the protection of orks to level 2.
@EttyKitty EttyKitty requested a review from OH296 November 10, 2024 10:33
EttyKitty
EttyKitty previously approved these changes Nov 10, 2024
@EttyKitty EttyKitty changed the title Bombardment fixes feat: Bombardment edits Nov 11, 2024
@EttyKitty EttyKitty merged commit 62a5ab2 into EttyKitty:compile/main Nov 11, 2024
@Blogaugis Blogaugis deleted the pr/14-bombcheck branch November 11, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Balance PR: Enhancement Makes something better PR: Misc Change A change with no distinct category PR: Refactor Rewriting/restructuring code, while keeping general behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants