Skip to content

Conversation

@jhillacre
Copy link

No description provided.

@jhillacre
Copy link
Author

sorry, lot's of whitespace changes in this one. if you use github's hide whitespace changes feature, the change should be clearer.

@EttyKitty
Copy link
Owner

EttyKitty commented Oct 27, 2024

sorry, lot's of whitespace changes in this one. if you use github's hide whitespace changes feature, the change should be clearer.

Np at all. It should imo be enforced that we use a JS formatted on all code, because old code is unreadable without it.
Maybe just do it in two commits/prs (not in this case). Or maybe someone just should run ALL code through a formatter in one pr.

Just a note, in case you use JS one - the one I use, breaks $"something {variable}" syntax by doing this $ "something {variable}. I manually run a search and replace "$ " to "$" afterwards.
And it also doesn't like "and" and "or". It doesn't automaticly place spaces between them and if conditions. I.e. if (condition) and(condition2). Doesn't happen with && and || though.

Copy link

@OH296 OH296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto merge no way it can go wrong i can see. Was this tested using the "inspection" cheat?

@jhillacre
Copy link
Author

I tested in a game where my world-based chapter was getting two inspectors, and now it gets one.

I did not test as a fleet-based chapter.

@EttyKitty EttyKitty merged commit 60d6760 into EttyKitty:compile/main Oct 27, 2024
@jhillacre jhillacre deleted the double-inspection branch October 27, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants