feat: improve the chapter fleet tab #69
Conversation
EttyKitty
added
PR: Enhancement
|
Edited the ship list a bit more: Screenshot
|
|
I'll pass the whole fleet tab file through a JS formmater when the PR is ready to merge. |
OH296
left a comment
OH296
left a comment
There was a problem hiding this comment.
cool stuff, got some suggestions very much in the take em or leave em category but worth considering imo
| if (escort[k] == obj_controller.temp[40]) then instance_create(x, y, obj_temp7); | ||
| } | ||
| } | ||
| if (instance_exists(obj_temp7)) { |
There was a problem hiding this comment.
if this is being redone can we please please deprecate the obj_temp7 usage
There was a problem hiding this comment.
if this is being redone can we please please deprecate the obj_temp7 usage
I would be glad, but I have no idea what obj_temp7 is, or what it does, or how to deprecate it. I just copy-pasted the code chunk, so that its click detection is where the button coords are.
So if you know how to - you can do that and I cherry pick. Or create a separate PR, maybe?
There was a problem hiding this comment.
literally instead of using arrays to compile lists of stuff the guy made instances of these crappy obj_temp7 things also used to be obj_temp4,obj_temp5,obj_temp6 but i think i've removed most of these, i can maybe do this if it's an issue
| if (point_and_click([_goto_button.x1, _goto_button.y1, _goto_button.x2, _goto_button.y2])) { | ||
| obj_controller.temp[40] = obj_ini.ship[i]; | ||
| with(obj_p_fleet) { | ||
| for (var k = 0; k <= 40; k++) { |
There was a problem hiding this comment.
without an array check length does this have a chance of causing crashes?
There was a problem hiding this comment.
without an array check length does this have a chance of causing crashes?
I'm not sure, but I haven't edited this code at all from where I copied it.
I assumed it being nested under 3 if checks and 1 for loop (that is limited as well) is enough of a failsafe.
2 participants
The code changes are simple, so you can just glance over them.
And the general look of the screen, I think it'll be easier to show before and after.
Before:
After: