Skip to content

Conversation

@EttyKitty
Copy link
Owner

There was a bug with captain's and chapter master names not displaying on the management screen - that I fixed.
There was a bug with captains and chapter master not de-selecting on drop select - that I fixed as well.

There is this

Deploy marines to ground combat but the captains was never there.I tried unload a captain alone on the enemy planet,next turn the ground combat didn't happen.I also tried unload a entire command squad,captain is still missing in combat.

bug, that I can't fucking fix. I've spent hours trying to find that fucking array that skips CM and Captains that are at index 0.

I can't. I give up.

image

@github-actions github-actions bot added the PR: Fix This is a fix for a bug label Nov 10, 2024
@OH296
Copy link

OH296 commented Nov 10, 2024

i have solutions on my own branch of this,will make a pr to this branch

fix: Enemy rows phasing through (#100)
fix: Captains and CM not taking part in battle (#100)
@EttyKitty EttyKitty marked this pull request as ready for review November 11, 2024 06:15
@EttyKitty EttyKitty added the PR: Refactor Rewriting/restructuring code, while keeping general behaviour label Nov 11, 2024
Copy link

@OH296 OH296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add suggestions then good to go

Co-authored-by: Nelsonh <81228864+OH296@users.noreply.github.com>
@EttyKitty EttyKitty changed the title fix: I abandon all hope to fix these arrays fix: Chapter Master and Captains missing in various places Nov 11, 2024
@EttyKitty EttyKitty merged commit 4d2936e into compile/main Nov 11, 2024
@EttyKitty EttyKitty deleted the fix/array-stroke branch November 11, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Fix This is a fix for a bug PR: Refactor Rewriting/restructuring code, while keeping general behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants