Skip to content
This repository was archived by the owner on Apr 29, 2022. It is now read-only.

Conversation

@umgelurgel
Copy link
Contributor

@umgelurgel umgelurgel commented Aug 9, 2019

The changes here result in an N+1 queries problem; as it's to an admin-only view that's only going to be used a handful of times a year, I'd rather not spend too much time fixing that :)

NB: this MR targets the ep2019 branch; this will need to be merged into the ep2020 branch, too

@umgelurgel umgelurgel force-pushed the issue-1089-add-mailer-reminding-speakers-to-upload-slides branch from 771fce7 to 99c2b1a Compare August 13, 2019 15:40
@umgelurgel umgelurgel force-pushed the issue-1089-add-mailer-reminding-speakers-to-upload-slides branch from 99c2b1a to 031866e Compare August 13, 2019 15:41
Copy link
Member

@aramboi aramboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@umgelurgel umgelurgel merged commit b966c34 into ep2019 Aug 13, 2019
@umgelurgel umgelurgel deleted the issue-1089-add-mailer-reminding-speakers-to-upload-slides branch January 1, 2020 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants