Skip to content

[DBX-34] Update API to get current database settings#3934

Merged
hayley-jean merged 1 commit intomasterfrom
kunaldhingra/db-15-new-api-to-get-current-database-settings
May 30, 2024
Merged

[DBX-34] Update API to get current database settings#3934
hayley-jean merged 1 commit intomasterfrom
kunaldhingra/db-15-new-api-to-get-current-database-settings

Conversation

@dhingrak
Copy link
Copy Markdown
Contributor

@dhingrak dhingrak commented Aug 16, 2023

Added: Add more information to the current database settings API response

Fixes: https://linear.app/eventstore/issue/DB-15/new-api-to-get-current-database-settings

The goal of this PR is to provide more information regarding the EventStoreDB database setting so the user who does not have access to the system can see how the database is configured. Attached the current API response and the new API response.

oldAPIresponse.txt
newAPIresponse.txt

@linear
Copy link
Copy Markdown

linear Bot commented Aug 16, 2023

DB-15 New API to get current database settings

When a user has no access to the box (for example, in ES Cloud), they can't see how the database is configured. For any sort of "control plane" it would be necessary to tell the Ops user what settings the database have. It will also make it easier for Ops people on the customer side to report their configuration to support when they open a ticket.

It's not directly related to the "change settings via API" project, but it seems connected.

Clarify: should the settings be persisted to the config file? Allow both temporary and permanent changes?

@dhingrak dhingrak self-assigned this Aug 16, 2023
Copy link
Copy Markdown
Contributor

@pvanbuijtene pvanbuijtene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few settings are missing and maybe need to decide how we want to expose the settings.

Comment thread src/EventStore.Core/ClusterVNodeOptions.cs Outdated
Comment thread src/EventStore.Core/Services/Transport/Http/Controllers/InfoController.cs Outdated
Comment thread src/EventStore.Core/ClusterVNodeOptions.cs Outdated
@dhingrak dhingrak force-pushed the kunaldhingra/db-15-new-api-to-get-current-database-settings branch 3 times, most recently from f60dca9 to 3110e48 Compare April 4, 2024 15:46
@hayley-jean hayley-jean changed the title Update API to get current database settings [DB-26-7] Update API to get current database settings Apr 22, 2024
@hayley-jean hayley-jean changed the title [DB-26-7] Update API to get current database settings [DB-26-17] Update API to get current database settings May 7, 2024
@dhingrak dhingrak force-pushed the kunaldhingra/db-15-new-api-to-get-current-database-settings branch 4 times, most recently from 9819de3 to a7d269a Compare May 16, 2024 17:11
@timothycoleman timothycoleman changed the title [DB-26-17] Update API to get current database settings [DBX-34] Update API to get current database settings May 20, 2024
Copy link
Copy Markdown
Contributor

@hayley-jean hayley-jean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add units (d) for ScavengeHistoryMaxAge since that's similar to the other time-based units

Comment thread src/EventStore.Core/Configuration/ClusterVNodeOptions.cs Outdated
Comment thread src/EventStore.Common/Configuration/UnitAttribute.cs Outdated
@dhingrak dhingrak force-pushed the kunaldhingra/db-15-new-api-to-get-current-database-settings branch from a7d269a to 88f5db8 Compare May 23, 2024 17:05
@dhingrak dhingrak requested a review from hayley-jean May 23, 2024 17:18
@hayley-jean hayley-jean merged commit 242e5a9 into master May 30, 2024
@hayley-jean hayley-jean deleted the kunaldhingra/db-15-new-api-to-get-current-database-settings branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants