[DB-379] Improve error messaging for non-existent projections in GRPC API#4197
Merged
thefringeninja merged 1 commit intomasterfrom Mar 14, 2024
Merged
Conversation
timothycoleman
changed the title
timothycoleman
requested changes
Mar 12, 2024
Contributor
timothycoleman
left a comment
timothycoleman
left a comment
There was a problem hiding this comment.
ive added some suggestions #4199 if you're happy we can squash the whole thingt into one commit
#2732, DB-379) This commit resolves the issue where querying non-existent projections through the Projection Management GRPC API returned an unclear 'UNKNOWN: Envelope callback expected Statistics, received NotFound instead' error. This fix introduces a clearer not found error message across the projection management operations Delete, Disable, Enable, Reset, Update, and Statistics (Status). There are currently no GRPC tests for this on the server validation was performed using the node client. Future improvements should include adding server-side GRPC tests for these scenarios. GitHub Issue: #2732 Linear Issue: https://linear.app/eventstore/issue/DB-379/grpc-listing-a-non-existant-projection-gives-a-poor-quality-error
daveremy
force-pushed
the
daveremy/db-379-proj-err-improve
branch
from
da0dc87 to
3f206fb
Compare
thefringeninja
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: Improve error messaging for non-existent projections in gRPC API
This commit resolves the issue where querying non-existent projections through the Projection Management GRPC API returned an unclear 'UNKNOWN: Envelope callback expected Statistics, received NotFound instead' error. This fix introduces a clearer not found error message across the projection management operations Delete, Disable, Enable, Reset, Update, and Statistics (Status).
There are currently no GRPC tests for this on the server. Validation was performed using the node client. Future improvements should include adding server-side GRPC tests for these scenarios. (https://linear.app/eventstore/issue/DB-698/consider-grpc-testing-strategy)
Fixes #2732
Related Linear Issue: DB-379 (https://linear.app/eventstore/issue/DB-379/grpc-listing-a-non-existant-projection-gives-a-poor-quality-error)