Expose current stream positions and retry count when consuming a subscriptions#144
Merged
thefringeninja merged 1 commit intotrunkfrom Jun 22, 2022
Merged
Expose current stream positions and retry count when consuming a subscriptions#144thefringeninja merged 1 commit intotrunkfrom
thefringeninja merged 1 commit intotrunkfrom
Conversation
YoEight
changed the title
oskardudycz
reviewed
May 6, 2022
db-client-java/src/main/java/com/eventstore/dbclient/EventStoreDBClient.java
Outdated
Show resolved
Hide resolved
oskardudycz
reviewed
May 6, 2022
db-client-java/src/main/java/com/eventstore/dbclient/PersistentSubscriptionListener.java
Outdated
Show resolved
Hide resolved
oskardudycz
reviewed
May 6, 2022
db-client-java/src/main/java/com/eventstore/dbclient/PersistentSubscriptionListener.java
Show resolved
Hide resolved
oskardudycz
reviewed
May 6, 2022
db-client-java/src/main/java/com/eventstore/dbclient/ReadSubscription.java
Outdated
Show resolved
Hide resolved
oskardudycz
reviewed
May 6, 2022
db-client-java/src/main/java/com/eventstore/dbclient/SubscriptionListener.java
Outdated
Show resolved
Hide resolved
YoEight
force-pushed
the
stream-position
branch
3 times, most recently
from
073a66e to
b2e4f1d
Compare
oskardudycz
reviewed
May 16, 2022
db-client-java/src/main/java/com/eventstore/dbclient/EventStoreDBClient.java
Outdated
Show resolved
Hide resolved
oskardudycz
reviewed
May 16, 2022
Contributor
oskardudycz
left a comment
oskardudycz
left a comment
There was a problem hiding this comment.
@YoEight, @hayley-jean, I'm not against such changes; they look fine. However, I think that we should make sure that this is the intended handling also in other clients. It is already different from .NET gRPC client. I'm not sure how other clients are dealing with it.
2 tasks
YoEight
force-pushed
the
stream-position
branch
3 times, most recently
from
12c8889 to
a8dff17
Compare
YoEight
force-pushed
the
stream-position
branch
3 times, most recently
from
9c61b46 to
355136f
Compare
hayley-jean
approved these changes
Jun 14, 2022
thefringeninja
approved these changes
Jun 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes: